[Workplace Search] Fix reauthenticate links for OneDrive and SharePoint #96271
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For both OneDrive and SharePoint we define a service_type that has an underscore in the middle (one_drive and share_point). This fixes the route definitions so sources of these connector types can be reauthenticated.
jgr
added
Feature:Plugins
release_note:skip
scottybollinger
approved these changes
Apr 6, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 6, 2021
For both OneDrive and SharePoint we define a service_type that has an underscore in the middle (one_drive and share_point). This fixes the route definitions so sources of these connector types can be reauthenticated.
kibanamachine
added a commit
that referenced
this pull request
Apr 6, 2021
For both OneDrive and SharePoint we define a service_type that has an underscore in the middle (one_drive and share_point). This fixes the route definitions so sources of these connector types can be reauthenticated. Co-authored-by: James Rucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For both OneDrive and SharePoint we define a service_type that has an
underscore in the middle (one_drive and share_point). This fixes the
route definitions so sources of these connector types can be
reauthenticated.
Without these changes, the "Fix" link for these sources 404's.
related to https://github.com/elastic/workplace-search-team/issues/1572